cURL / Mailing Lists / curl-users / Single Mail

curl-users

Re: [PATCH] save metadata to extended file attributes

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 8 Nov 2010 09:38:30 +0100 (CET)

On Mon, 8 Nov 2010, Kamil Dudka wrote:

> I still see a typo in comment:

I fixed that now. Thanks.

> It might be useful to define a macro template as base of CURL_INCLUDES_*
> macros. The copy/paste approach seems to be less reliable and harder to
> maintain.

I agree. There are a whole bunch of very similar functions in there and I'm
sure we can improve them a lot so that they we don't have to duplicate so much
code in order to add new checks (thus reducing the risk of future mistakes
such as the ones I just did). It's just a bit of tedious and ungrateful kind
of work so I figure nobody has yet considered it important enough...

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ:        http://curl.haxx.se/docs/faq.html
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-11-08