cURL / Mailing Lists / curl-users / Single Mail

curl-users

Re: [PATCH] save metadata to extended file attributes

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Mon, 8 Nov 2010 09:32:42 +0100

On Monday 08 November 2010 09:12:41 Daniel Stenberg wrote:
> On Sun, 7 Nov 2010, Stefan Tomanek wrote:
> > For some reason, configure does not enable xattr support here:
>
> Sorry, my mistake. I did a copy and paste of another test but failed to
> edit it properly. I've now edited the test further, I verified that it
> indeed works in my end and I also fixed a compiler warning in src/xattr.c
> and then I pushed my fixes.

I still see a typo in comment:

dnl CURL_INCLUDES_SYS_XATTR
dnl -------------------------------------------------
dnl Set up variable with list of headers that must be
dnl included when sys/uio.h is to be included.

It might be useful to define a macro template as base of CURL_INCLUDES_*
macros. The copy/paste approach seems to be less reliable and harder to
maintain.

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ: http://curl.haxx.se/docs/faq.html
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-11-08