cURL / Mailing Lists / curl-users / Single Mail

curl-users

Re: Patch to use filename from Content-disposition header

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 11 Jan 2010 22:08:25 +0100 (CET)

On Sun, 10 Jan 2010, Kamil Dudka wrote:

> attached is an incremental patch with some comments inside.

+ const size_t rv = (sz * nmemb) ? 1 : 0;

This is a mistake. As 'rv' is used to reture failure, we must make sure it
isn't the same value as was given as input. Thus I instead suggest we make
it:

   const size_t rv = (sz * nmemb) ? 0 : 1;

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ:        http://curl.haxx.se/docs/faq.html
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-01-11