On Fri, 1 Jan 2010, Kamil Dudka wrote:

> On Thursday 31 of December 2009 21:49:21 Björn Stenberg wrote:
>> The cost of adding something like the suggested fdopen solution is code
>> confusiion. If we add it here, future readers will ask themselves why it
>> was done this way and if it is something that should be done elsewhere too.
>
> Fair enough. Sometimes I contribute to the GNU coreutils project, where your
> approach would be definitely not feasible. However it might be sufficient
> and maybe more portable solution for curl.

I think you have a point Kamil but as Björn says I'm not sure the race is an
actual problem here.

We need of course need to make sure that there's a big comment in the code
explaining this reasoning, to make sure future readers understand how we've
reasoned around this subject.

-- 
  / daniel.haxx.se

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ: http://curl.haxx.se/docs/faq.html
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-01-01