I just wanted to give my two pennies worth as I have some Win32 pthread experience and am hoping to bring that to curl at some point in the future.

Given that the malloc's of t and ac could fail independently (although fairly unlikely) but then be caught by the if after the ac malloc, wouldn't it be better to use Curl_safefree() instead of free?

---
** [bugs:#1314] Build failure cross-compiling for x86_64-w64-mingw32 target**
**Status:** closed-fixed
**Created:** Mon Dec 23, 2013 05:01 PM UTC by Luke-Jr
**Last Updated:** Tue Dec 24, 2013 11:44 PM UTC
**Owner:** Daniel Stenberg
OS: Gentoo stable x86 (32-bit)
Target: crossdev x86_64-w64-mingw32 (MingW64)
Versions affected: at least 7.33.0 and 7.34.0
curl_threads.c: In function 'Curl_thread_create':
curl_threads.c:69:5: error: conversion to non-scalar type requested
curl_threads.c:76:5: error: conversion to non-scalar type requested
curl_threads.c: In function 'Curl_thread_destroy':
curl_threads.c:84:3: error: conversion to non-scalar type requested
curl_threads.c: In function 'Curl_thread_join':
curl_threads.c:92:3: error: conversion to non-scalar type requested
---
Sent from sourceforge.net because curl-tracker@cool.haxx.se is subscribed to https://sourceforge.net/p/curl/bugs/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/curl/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.