Bugs item #3079891, was opened at 2010-10-02 01:30
Message generated for change (Comment added) made by danlocks
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=3079891&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: compile or build problem
Group: bad behaviour
Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Dan Locks (danlocks)
Assigned to: Daniel Stenberg (bagder)
Summary: --with-libcurl treats value as a prefix

Initial Comment:
The macro docs/libcurl/libcurl.m4 states [--with-libcurl=DIR],[look for the curl library in DIR], but treats the value given as a prefix, appending bin, include or lib.

Which is better: changing the code match the help string, or the way around? Personally I prefer changing the code.

I also submitted a pull request on github for this issue.

----------------------------------------------------------------------

>Comment By: Dan Locks (danlocks)
Date: 2010-10-04 17:13

Message:
That's great! thanks a lot. This change will make it into the next
release of Amanda.

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2010-10-04 12:01

Message:
This change has now been pushed to the git repo.

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2010-10-04 03:44

Message:
In my view, most options like --with-lib* tend to point out the PREFIX.
(again since it needs headers as well, only pointing out the lib dir makes
little sense in most cases)

I rather not change the name of the option since that may surprise users
who would upgrade to this from the older version. But I can certainly
update the docs string to better reflect what it actually is doing.

----------------------------------------------------------------------

Comment By: Dan Locks (danlocks)
Date: 2010-10-03 13:21

Message:
My attached patch does it this way:
+ libcurl_with_prefix=`dirname $withval`
+ LIBCURL_CPPFLAGS="-I$libcurl_with_prefix/include"

However, I was a trying to make the configure option act like other
--with-lib* options.

Since treating $withval as a prefix was intentional, how about this:
- AC_ARG_WITH(libcurl,
- AC_HELP_STRING([--with-libcurl=DIR],[look for the curl library in
DIR]),
+ AC_ARG_WITH(libcurl-prefix,
+ AC_HELP_STRING([--with-libcurl-prefix=PREFIX],
+ [look for the curl library in PREFIX/lib ]),

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2010-10-02 07:12

Message:
I think it makes the most sense to use that option with a prefix, not the
exact path as where would it otherwise check for the include headers for
example?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=3079891&group_id=976
Received on 2010-10-05