Bugs item #1662003, was opened at 2007-02-16 17:06
Message generated for change (Comment added) made by danlocks
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1662003&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: compile or build problem
Group: portability problem
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Ian Turner (vectro)
Assigned to: Daniel Stenberg (bagder)
Summary: --with-libcurl doesn't work right

Initial Comment:
The sample autoconf macro distributed as docs/libcurl/libcurl.m4 doesn't properly search for check-config when the --with-libcurl commandline is used.

The problem is that AC_PATH_PROG already appends the path, which you should override with the third argument (not the second).

This patch should do the job:

--- broken/libcurl.m4
+++ fixed/libcurl.m4
@@ -1166,7 +1166,7 @@
      if test -d "$_libcurl_with" ; then
         LIBCURL_CPPFLAGS="-I$withval/include"
         _libcurl_ldflags="-L$withval/lib"
- AC_PATH_PROG([_libcurl_config],["$withval/bin/curl-config"])
+ AC_PATH_PROG([_libcurl_config],[curl-config],["$withval/bin"])
      else
         AC_PATH_PROG([_libcurl_config],[curl-config])
      fi

----------------------------------------------------------------------

Comment By: Dan Locks (danlocks)
Date: 2010-10-02 01:40

Message:
oh, I submitted a github pull request which includes this change.

----------------------------------------------------------------------

Comment By: Dan Locks (danlocks)
Date: 2010-10-02 01:39

Message:
I suspect autoconf may have changed their spec for AC_PATH_PROG again.
It's currently defined as:
AC_PATH_PROG (variable, prog-to-check-for, [value-if-not-found], [path =
‘$PATH’])

The third argument should either be a default full path of a program (not
a search path), or nothing. So the new preferred invocation here would be:

AC_PATH_PROG([_libcurl_config],[curl-config],[],["$withval/bin"])
else
AC_PATH_PROG([_libcurl_config],[curl-config],[],["$PATH"])

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2007-02-19 06:38

Message:
Logged In: YES
user_id=1110
Originator: NO

Thanks, your fix was applied and committed to CVS just now.

----------------------------------------------------------------------

Comment By: Ian Turner (vectro)
Date: 2007-02-16 17:21

Message:
Logged In: YES
user_id=4941
Originator: YES

Oops, I got it wrong. The following patch is preferred:

--- broken/libcurl.m4
+++ fixed/libcurl.m4
@@ -1166,7 +1166,7 @@
      if test -d "$_libcurl_with" ; then
         LIBCURL_CPPFLAGS="-I$withval/include"
         _libcurl_ldflags="-L$withval/lib"
- AC_PATH_PROG([_libcurl_config],["$withval/bin/curl-config"])
+
AC_PATH_PROG([_libcurl_config],[curl-config],["$withval/bin"],["$withval/bin"])
      else
         AC_PATH_PROG([_libcurl_config],[curl-config])
      fi

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1662003&group_id=976
Received on 2010-10-02