Bugs item #612432, was opened at 2002-09-21 09:22
Message generated for change (Comment added) made by bagder
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=612432&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: perl binding
Group: wrong behaviour
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Dave Huang (dahanc)
Assigned to: Cris Bailiff (crisb)
Summary: CURLOPT_PROGRESSFUNCTION broken in Perl

Initial Comment:
The CURLOPT_PROGRESSFUNCTION callback doesn't work
properly in the Perl binding. The curl.h file declares
the progress callback as:

typedef int (*curl_progress_callback)(void *clientp,
                                      double dltotal,
                                      double dlnow,
                                      double ultotal,
                                      double ulnow);

However, the Perl binding's easy.xs declares it as:

static int progress_callback_func(void *clientp, size_t
dltotal, size_t dlnow,
    size_t ultotal, size_t ulnow)

Of course, this causes the returned numbers to be
completely incorrect.

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2008-10-09 10:38

Message:
Hey sandburg,

First, don't confuse the perl binding with libcurl. libcurl's API for the
callbacks will not change in the next release and in fact isn't planned for
any release. The problems mentioned in this report is not a flaw in libcurl
as it supports all this just fine.

I would also suggest that perl binding flaws are reported to the
author/maintainer of it, as he/they are not working inside the curl project
and thus won't read things you report to us!

----------------------------------------------------------------------

Comment By: Sandburg (sandburg)
Date: 2008-10-09 10:32

Message:
No, it is not fixed...
until this f***** functions will need to be static !!!

all the callbacks in CURL need to be static, that is really a bad ID !
How can you build objects with it, how can you instanciate multiple
downloads... static is a poison gift.
CURL is high level librairy for http/ftp protocol, but however, many low
level infos (such as DL speed, size of the file while resuming...) are
missing. And that "static" mistake don't help for having the missing
infos.
I guess in a next version of CURL, the callbacks will not be static
anymore !

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2002-09-24 09:33

Message:
Logged In: YES
user_id=1110

Closed report as fixed.

(Added category "perl binding" and I also made crisb default
receiver of those reports and I you should now be able to
close and edit reports too Cris!)

----------------------------------------------------------------------

Comment By: Cris Bailiff (crisb)
Date: 2002-09-23 04:39

Message:
Logged In: YES
user_id=38466

OK - this is fixed in Curl::easy 1.35, now released. I can't
see how to close this ticket on sourceforge though. Guess I
don't have permissions..

Cris

----------------------------------------------------------------------

Comment By: Cris Bailiff (crisb)
Date: 2002-09-22 03:10

Message:
Logged In: YES
user_id=38466

Hmm, I'm sure it used to work. Maybe the libcurl function
signature changed along the way - it's been a long time
since I used that feature.

I'll fix up a new version of Curl-easy this evening.

Cris
(P.S. Daniel, any idea how I 'take' this ticket and/or close
it when it's done?)

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=612432&group_id=976
Received on 2008-10-09