Bugs item #1812190, was opened at 2007-10-12 13:45
Message generated for change (Comment added) made by bagder
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1812190&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: libcurl
Group: wrong behaviour
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Mikhail (gibigaba)
Assigned to: Daniel Stenberg (bagder)
>Summary: libcurl can use wrong connection, when using proxy tunnel

Initial Comment:
libcurl in some cases use wrong connection, when connected to different https servers(or one server and different ports) via same proxy.

following changes to url.c can fix the problem:

C:\...\home\Mikhail\inst\curl-7.17.0-hacked\lib>diff ..\..\curl-7.17.0\lib\url.c url.c
2219,2223c2219
< if(!needle->bits.httpproxy || needle->protocol&PROT_SSL ||
< (needle->bits.httpproxy && check->bits.httpproxy &&
< needle->bits.tunnel_proxy && check->bits.tunnel_proxy &&
< strequal(needle->proxy.name, check->proxy.name) &&
< (needle->port == check->port))) {

---
>     if(!needle->bits.httpproxy || needle->protocol&PROT_SSL) {
----------------------------------------------------------------------
>Comment By: Daniel Stenberg (bagder)
Date: 2007-10-23 23:01
Message:
Logged In: YES 
user_id=1110
Originator: NO
comitted!
----------------------------------------------------------------------
Comment By: Daniel Stenberg (bagder)
Date: 2007-10-22 23:26
Message:
Logged In: YES 
user_id=1110
Originator: NO
Ok, I've attached an updated patch. Can you just give it a quick
test/review and see if you agree with this? It should make your case work
and still make test 275 run fine...
File Added: fix-proxy-tunnel-3.patch
----------------------------------------------------------------------
Comment By: Daniel Stenberg (bagder)
Date: 2007-10-22 23:16
Message:
Logged In: YES 
user_id=1110
Originator: NO
This patch breaks test 275. I'm looking at how to fix it...
----------------------------------------------------------------------
Comment By: Daniel Stenberg (bagder)
Date: 2007-10-22 16:08
Message:
Logged In: YES 
user_id=1110
Originator: NO
Right, then I understand the patch better. Your summary for this entry
says https...
----------------------------------------------------------------------
Comment By: Mikhail (gibigaba)
Date: 2007-10-22 14:04
Message:
Logged In: YES 
user_id=1671616
Originator: YES
AFAIK: it not set when HTTP protocol used via tunneling proxy connection.
When there are two tunneled connections to the same host, but to different
ports. Wrong connection can be re-used.
----------------------------------------------------------------------
Comment By: Daniel Stenberg (bagder)
Date: 2007-10-22 11:54
Message:
Logged In: YES 
user_id=1110
Originator: NO
isn't PROT_SSL set in needle->protocol if you use HTTPS?
----------------------------------------------------------------------
Comment By: Mikhail (gibigaba)
Date: 2007-10-12 17:39
Message:
Logged In: YES 
user_id=1671616
Originator: YES
Previous was wrong direction... This might be right.
--- ..\..\curl-7.17.0\lib\url.c 2007-09-03 03:53:15.000000000 +0600
+++ url.c       2007-10-12 21:39:38.765625000 +0600
@@ -2216,7 +2216,11 @@
       /* don't do mixed SSL and non-SSL connections */
       continue;
-    if(!needle->bits.httpproxy || needle->protocol&PROT_SSL) {
+    if(!needle->bits.httpproxy || needle->protocol&PROT_SSL ||
+      (needle->bits.httpproxy && check->bits.httpproxy &&
+       needle->bits.tunnel_proxy && check->bits.tunnel_proxy &&
+       strequal(needle->proxy.name, check->proxy.name) &&
+       (needle->port == check->port))) {
       /* The requested connection does not use a HTTP proxy or it
          uses SSL. */
----------------------------------------------------------------------
Comment By: Mikhail (gibigaba)
Date: 2007-10-12 17:36
Message:
Logged In: YES 
user_id=1671616
Originator: YES
sure
--- ..\..\curl-7.17.0\lib\url.c 2007-10-12 17:34:23.312500000 +0600
+++ url.c       2007-09-03 03:53:15.000000000 +0600
@@ -2216,11 +2216,7 @@
       /* don't do mixed SSL and non-SSL connections */
       continue;
-    if(!needle->bits.httpproxy || needle->protocol&PROT_SSL ||
-      (needle->bits.httpproxy && check->bits.httpproxy &&
-       needle->bits.tunnel_proxy && check->bits.tunnel_proxy &&
-       strequal(needle->proxy.name, check->proxy.name) &&
-       (needle->port == check->port))) {
+    if(!needle->bits.httpproxy || needle->protocol&PROT_SSL) {
       /* The requested connection does not use a HTTP proxy or it
          uses SSL. */
----------------------------------------------------------------------
Comment By: Daniel Stenberg (bagder)
Date: 2007-10-12 13:51
Message:
Logged In: YES 
user_id=1110
Originator: NO
Can you please provide the patch done with diff -u ?
----------------------------------------------------------------------
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1812190&group_id=976