Bugs item #1733119, was opened at 2007-06-08 00:43
Message generated for change (Comment added) made by bagder
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1733119&group_id=976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: libcurl
Group: wrong behaviour
Status: Open
Resolution: None
>Priority: 6
Private: No
Submitted By: rrauenza (rrauenza)
Assigned to: Daniel Stenberg (bagder)
Summary: socket.c assumes xopen getsockopt/getsockname

Initial Comment:

HPUX doesn't use the XOPEN getsockopt/getsockname interfaces by default (for backwards compatibility).

     int setsockopt(
          int s,
          int level,
          int optname,
          const void *optval,
          int optlen
      );

    _XOPEN_SOURCE_EXTENDED Only (UNIX 98)
      int getsockopt(
          int s,
          int level,
          int optname,
          void *optval,
          socklen_t *optlen
      );

When compiling 64bit, socklen_t is 64bit, but int is 32bit, so optlen ends up being 0 due the socklen being treated as a 32bit value.

Here's the required changes -- simply changing the parms to be ints instead of socklens when not using _XOPEN_SOURCE_EXTENDED and HPUX

$ rcsdiff connect.c
RCS file: connect.c,v
retrieving revision 1.1
rdiff -r1.1 connect.c
367a368,370
> #if defined(__hpux) && ! defined(_XOPEN_SOURCE_EXTENDED)
> int size;
> #else
368a372
> #endif
407a412,414
> #if defined(__hpux) && ! defined(_XOPEN_SOURCE_EXTENDED)
> int errSize = sizeof(err);
> #else
408a416
> #endif

----------------------------------------------------------------------

>Comment By: Daniel Stenberg (bagder)
Date: 2007-06-08 10:10

Message:
Logged In: YES
user_id=1110
Originator: NO

Can you please submit the patch done with diff -u ? I'm having trouble
reading it unless there's some context in it as well.

Is there any particular reason why we shouldn't just try to define
_XOPEN_SOURCE_EXTENDED properly and make your system act/work like other
systems instead? I'd really hate to add such a kludgey #ifdef mess in at
least three different source files. It'll also just beg for this to happen
the next time we add such a function call or modify one of the existing.

I would really prefer a way that cures the problem without relying on
#ifdefs where getsockopt() is used. You think that is possible?

----------------------------------------------------------------------

Comment By: rrauenza (rrauenza)
Date: 2007-06-08 01:58

Message:
Logged In: YES
user_id=1309815
Originator: YES

Looks like ftp.c and tftp.c also need to be fixed. Anywhere those calls
are made.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100976&aid=1733119&group_id=976
Received on 2007-06-08