Re: time to remove Visual Studio project files?

> 5) It's easy to automatically patch the XML project files to compile with
all warnings enabled (/Wall, corresponds to clang's -Weverything) and only
the expected warnings disabled as they are per Visual Studio version
I could live with /W4 though.

In CMake you should be able to do: `set(CMAKE_CXX_FLAGS "/Wall") ` to
always set the "/Wall" warning flag or any other flag, and if you want it
to be cross-compiler, you just do some `if(CMAKE_CXX_COMPILER_ID STREQUAL
"MSVC")`
`CXX` can be replaced with `C` if you use C, and not C++.

søn. 6. sep. 2020 kl. 13:17 skrev Marcel Raad via curl-library <
curl-library_at_cool.haxx.se>:

> Hi,
>
> > -----Original Message-----
> > From: curl-library <curl-library-bounces_at_cool.haxx.se> On Behalf Of
> Daniel
> > Stenberg via curl-library
> > Sent: Saturday, 5 September 2020 15:16
> > To: libcurl hacking <curl-library_at_cool.haxx.se>
> > Cc: Daniel Stenberg <daniel_at_haxx.se>
> > Subject: time to remove Visual Studio project files?
> >
> > I'd like to get a better feel for the need to ship the visual studio
> project files we
> > currently host in the project/ directory.
> >
> > Do you use them? Why isn't generating these files using cmake good
> enough?
>
> I'm currently using them (slightly patched). nmake/winbuild is currently
> not an option as it lacks a lot of options. The main reasons for not using
> CMake are/were, in order of importance:
>
> 1) It wasn't possible to set the target Windows for a long time
> This is now fixed with
> https://github.com/curl/curl/commit/295ea5f641cb3d6ca44bb949e63bd1070835a872
> .
>
> 2) HTTP_ONLY leaves SMB enabled
> See https://github.com/curl/curl/pull/3770 for the reverted fix. It could
> probably be revived now that
> https://github.com/curl/curl/commit/f504f18641ebedde8e8b3805472267efa9a9b528
> has landed.
>
> 3) Tests passing with VS project-built curl were failing with CMake-built
> curl in configurations important to me
> This should be fixed with
> https://github.com/curl/curl/commit/f504f18641ebedde8e8b3805472267efa9a9b528.
> I still have to verify if all tests in all configurations are passing now
> though.
>
> 4) It still outputs a big fat warning on every CMake run that it's poorly
> maintained, so it just feels like it's experimental and not the recommended
> way to build
>
> 5) It's easy to automatically patch the XML project files to compile with
> all warnings enabled (/Wall, corresponds to clang's -Weverything) and only
> the expected warnings disabled as they are per Visual Studio version
> I could live with /W4 though.
>
> I'm happy to check if we can migrate to CMake, but I'm not sure if a week
> will be enough for a final decision. It might take two, or maybe even
> longer if further fixes to curl's CMake system are needed.
>
> Marcel
>
> -------------------------------------------------------------------
> Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
> Etiquette: https://curl.haxx.se/mail/etiquette.html

-- 
- Tomas

-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2020-09-07