curl / Mailing Lists / curl-library / Single Mail
Buy commercial curl support from WolfSSL. We help you work out your issues, debug your libcurl applications, use the API, port to new platforms, add new features and more. With a team lead by the curl founder himself.

Re: Regarding issue filed https://github.com/curl/curl/issues/5523

From: Daniel Stenberg via curl-library <curl-library_at_cool.haxx.se>
Date: Sun, 16 Aug 2020 00:45:16 +0200 (CEST)

On Sat, 15 Aug 2020, Shilpa Gupta via curl-library wrote:

> I think something needs to be fixed around
> https://github.com/curl/curl/blob/aecce3551cbb62a7980e8d22b40eabc091f896a0/lib/vtls/vtls.c#L330
> Since I am looking at the libcurl code first time. I can't put a finger of
> what should be the fix here. I would really appreciate some guidance in
> terms of what is a possible fix here. I can send a pull request.

The https proxy code logic is a bit funny and I'm not totally "fluent" in it
either, which is why I've felt a little lost when I looked at #5523. I would
need to spend more time on it to get into the details and figure out how to
fix it properly. Time I yet haven't had or felt I had the energy to spend on
it (and nobody has paid me to). I suspect #4295 suffers from a similar (or
perhaps the same) mixup in the code.

-- 
  / daniel.haxx.se | Commercial curl support up to 24x7 is available!
                   | Private help, bug fixes, support, ports, new features
                   | https://www.wolfssl.com/contact/
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html
Received on 2020-08-16