Download
Browse source Changelog
Documentation
Project   Bug Bounty   Help us   Known bugs   TODO Protocols   CA bundle   HTTP Cookies   HTTP/2   SSL Certs Releases   Security   Version numbers   Vulnerabilities curl tool   man page   Tutorial   HTTP scripting Who and Why
libcurl
ABI API Competitors Examples Features Mailing list Related libs Using libcurl Tutorial Testimonials
Get Help
curl-library curl-users Mailing lists Book: Everything curl Video presentations Report a bug Paid support
Development
Autobuilds Code Style Contribute Deprecate Internals Release Notes Release Procedure Roadmap Run Tests Security Process Specifications Test curl
News
Changelog Release table
curl / Mailing Lists / curl-library / Single Mail
Buy commercial curl support from WolfSSL. We help you work out your issues, debug your libcurl applications, use the API, port to new platforms, add new features and more. With a team lead by the curl founder himself.

Re: Nmake install prefix

From: Thomas Gamper via curl-library <curl-library_at_cool.haxx.se>
Date: Sun, 16 Jun 2019 15:54:41 +0200

Hi,

I handle it identically to WITH_DEVEL, so I think it may be fine.

Created a pull request: https://github.com/curl/curl/pull/4031

Thanks,
Thomas

Am 16.06.2019 um 12:18 schrieb Rod Widdowson via curl-library:
>> Any Windows developer who would object?
> Not from here. Looks pretty benign.
>
> Some side notes:
>
> I can never remember under what circumstances NMAKE inherits environmental variable (with and withour /e) so I cannot work out whether this wouldn't either need some work in Makefile.vc and/or whether you can just doing by condionalizing the setting of DESTDIR on DESTDIR. Also whether it works from the command line as well as in the environment...
>
> If this is a supported variable you need to make a suitable change to MakeFile.vc (alongside WITH_DEVEL and so on).
>
> Finally as a general code thing I think I'd prefer
>
> !IFDEF WITH_PREFIX
> DIRDIST = $(WITH_PREFIX)
> !ELSE
> DIRDIST = ..\builds\$(CONFIG_NAME_LIB)\
> !ENDIF
>
> Finally, if you take this to Github can someone mark me a reviewer and I'll try to do a test build? I recently stopped getting all github mails for curl since I was getting swamped...
>
> R
>
>
> -------------------------------------------------------------------
> Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
> Etiquette: https://curl.haxx.se/mail/etiquette.html
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2019-06-16