Hi Daniel,

    To be specific with the change you don't get anymore a static NTLM
string which you can compare for the failing tests 2025, ...

Regards
Markus

-----Original Message-----
From: Markus Moeller via curl-library
Sent: Tuesday, December 11, 2018 11:24 PM Newsgroups:
gmane.comp.web.curl.library
To: Daniel Stenberg ; Markus Moeller via curl-library
Cc: Markus Moeller
Subject: Re: NTLMV2 authentication;

Hi Daniel,

  Thank you for the feedback, but I still do not understand how I can change
the tests.

Regards
Markus

-----Original Message-----
From: Daniel Stenberg
Sent: Tuesday, December 11, 2018 11:40 AM
To: Markus Moeller via curl-library
Cc: Markus Moeller
Subject: Re: NTLMV2 authentication;

On Sun, 9 Dec 2018, Markus Moeller via curl-library wrote:

> How can I progress the patch https://github.com/curl/curl/pull/3287 I
> provided ?
>
> Could others test against an AD which allows the different combinations
> and in particular the last i.e DCs refuse LM and NTLM (accept only NTLMv2
> authentication) to confirm the changes work in all cases ? It seems to
> work for me.

I'd like to see two things happen:

1. The PR needs to fix the test failures. We can't merge anything that
knowingly breaks tests. You need to update the tests with the new protocol
data that ends up being used because of the changed bits.

2. Confirmation by one or two other users that NTLM still works. Since our
test cases don't really know NTLM and just verify that we keep using it like
before, we need to verify that this doesn't break existing behaviors against
some actual NTLM end-points.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html 
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html