On 12/07/2018 06:52 AM, Daniel Stenberg wrote:
> On Fri, 7 Dec 2018, Ben Greear wrote:
>
>> I recently rebased this patch and did a new pull request (pull requests are not my specialty, possibly I did that wrong).
>
> Are you talking about https://github.com/curl/curl/pull/2177 ?
>
> It still has compiler warnings: https://travis-ci.org/curl/curl/jobs/460883263#L3654

I didn't realize that... I just took a look at that link above and I'm not sure from the output how
to reproduce this build failure.

Do you know how I might reproduce this failure on my system, or do you see what
part of my patch is causing this issue? For what its worth, it builds clean on
all of my many systems...

>> Even if you don't want to take the other two compile fixup patches we recently discussed, could you give consideration to the LOCALADDR patch?
>
> I replied regarding one of your suggested fixes earlier today. I made a PR out of it.

Thanks, I found that email...must have gotten up too early this morning!

Thanks,
Ben

-- 
Ben Greear <greearb_at_candelatech.com>
Candela Technologies Inc  http://www.candelatech.com
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html