curl-library
ENABLE_OPENSSL_AUTO_LOAD_CONFIG for Windows wrong?
Date: Thu, 1 Nov 2018 09:08:29 +0100
Hi,
I usually turn off reading openssl config file.
So on Windows, the makefile.vc defines the option:
!MESSAGE ENABLE_OPENSSL_AUTO_LOAD_CONFIG=<yes or no>
I pass ENABLE_OPENSSL_AUTO_LOAD_CONFIG=no to nmake to set no.
The Makefile checks if it's defined and should not set it to true for me:
!IFNDEF ENABLE_OPENSSL_AUTO_LOAD_CONFIG
ENABLE_OPENSSL_AUTO_LOAD_CONFIG = true
!ENDIF
In MakefileBuild.vc I see this comparison to add option:
!IF "$(ENABLE_OPENSSL_AUTO_LOAD_CONFIG)"=="false"
SSL_CFLAGS = $(SSL_CFLAGS) /DCURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG
!ENDIF
And it looks like the #ifndef CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG in C code doesn't get set.
Do we need this for ENABLE_OPENSSL_AUTO_LOAD_CONFIG to convert from yes/no to true/false?
So a fix fro MakefileBuild.vc could be to add an extra branch for no in addition to false:
!IF "$(ENABLE_OPENSSL_AUTO_LOAD_CONFIG)"=="no"
SSL_CFLAGS = $(SSL_CFLAGS) /DCURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG
!ENDIF
Can someone confirm?
Sincerely
Christian
-- Read our blog about news on our plugins: http://www.mbsplugins.de/ ------------------------------------------------------------------- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.htmlReceived on 2018-11-01