curl / Mailing Lists / curl-library / Single Mail

curl-library

Re: Slow Windows uploads (with patch)

From: Daniel Jeliński <djelinski1_at_gmail.com>
Date: Fri, 20 Jul 2018 10:29:55 +0200

2018-07-19 18:45 GMT+02:00 Daniel Stenberg <daniel_at_haxx.se>:
> https://github.com/curl/curl/pull/2762

Thank you! I see that the test builds succeeded. What's next?

Meanwhile I went to check if this will benefit MinGW users. I found that:
- MinGW headers do not define SIO_IDEAL_SEND_BACKLOG_QUERY
- MinGW policy [1] suggests that they may be unwilling to accept a
patch with that define, as its value is only available in MS headers
and not in documentation

So in its current form the patch won't help MinGW. Other MinGW
projects worked around that problem by creating that #define in their
own code [2]. Barring that, the next best available option for MinGW
users is to determine optimal buffer size using trial and error, or
just set it as large as possible. Should we put that in the
documentation?
Thanks,
Daniel

[1] http://www.mingw.org/wiki/SubmitPatches
[2] https://trac.torproject.org/projects/tor/ticket/22798#comment:60
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2018-07-20