curl / Mailing Lists / curl-library / Single Mail

curl-library

Re: [curl/curl] f30420: mime: fix an explicit null dereference (#1899)

From: Ben Greear <greearb_at_candelatech.com>
Date: Wed, 20 Sep 2017 04:49:40 -0700

On 09/20/2017 04:38 AM, Daniel Stenberg wrote:
> On Wed, 20 Sep 2017, Ben Greear wrote:
>
>>> mime: fix an explicit null dereference (#1899)
>>
>> Why is it that no diff is included in these mails? Without the diff, it is more work to do a casual review of the patch...
>
> Primarily because github doesn't offer that feature built-in. =(
>
> I never spent the required time and energy to write my own service that does the job, which would be possible since we can get github to send over detailed commit info as JSON for each commit... Personally I basically always have at least one tab open on the curl github repo anyway.
>
> Looking further into this issue now, it seems gitdub might be a solution to exactly this: https://github.com/mavam/gitdub

Ohh, I would have thought it would work by default...guess I don't pay a lot of attention to my own
github pushes.

In case you get time to make the diff show up in the mail, I think it would be a nice feature.

Thanks,
Ben

-- 
Ben Greear <greearb_at_candelatech.com>
Candela Technologies Inc  http://www.candelatech.com
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html
Received on 2017-09-20