curl / Mailing Lists / curl-library / Single Mail

curl-library

Re: smb.c and remote-time

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 4 Jul 2017 15:56:38 +0200 (CEST)

On Tue, 4 Jul 2017, Gisle Vanem via curl-library wrote:

> it's nice to see SMB is getting some focus (although I'm not able to run
> these tests on my StrawberryPerl).

Right, the test server for SMB is python...

> 1) '_getpid()' is not a valid function in djgpp/MSDOS. Simple fix:

I merged your fix in commit f8dba473a.

> 2) A "curl --remote-time .." does nothing for smb://. Seems to be a matter
> of using the 'smb_nt_create_response::last_change_time' struct-member. The
> attached diff seems to work here.

Lovely. I've pushed it as a PR to get it through the CI before merge:
https://github.com/curl/curl/pull/1643

I'll see if I can make a test for it...

Thanks!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html
Received on 2017-07-04