curl / Mailing Lists / curl-library / Single Mail


Re: looking at commit 3ab3c16db6a5674f53cf23d56512a405fde0b2c9

From: Daniel Stenberg <>
Date: Wed, 21 Dec 2016 23:27:48 +0100 (CET)

On Wed, 21 Dec 2016, Ray Satiro via curl-library wrote:

>> +#define MAXIMIZE
>> -179769313486231570814527423731704356798070567525844996598917476803157260780028538760589558632766878171540458953514382464234321326889464182768467546703537516986049910576551282076245490090389328944075868508455133942304583236903222948165808559332123348274797826204144723168738177180919299881250404026184124858368.000000
>> +
>> #define DBL_MAX 1.7976931348623157081452E+308
>> But you have it spelled out way across my editor. Just .. curious here.
> I'm also curious about this, it is causing problems for Visual Studio 2012
> and 2013 CI on appveyor [1]:
> C:\projects\curl\tests\libtest\lib557.c(1632): fatal error C1064: compiler
> limit : token overflowed internal buffer
> [C:\projects\curl\build.msvc2012\tests\libtest\lib557.vcxproj]


I just happened to get that value as part of a conversation and
since I didn't want to add a dependency on float.h and risk a portability
problem with systems using different values or whatever, I simply added the
define there.

I suppose using 1.7976931348623157081452E+308 causes less friction. Doesn't

> Other VS versions it seems to be ok. Also that file has a number a few
> issues caught by checksrc.bat but not regular checksrc. Is it supposed to
> check that file?

Oh. If I run 'make checksrc' I get those warnings too. But not when I build
regularly or build in tests (which is my regular method to see those
warnings). I'll look into fixing this.

List admin:
Received on 2016-12-21