On Fri, 11 Nov 2016, Kamil Dudka wrote:

> Yes, we do not expect a "valid host name". What about the following wording?
>
> "Expected 'localhost' or empty string as host name in file:// URL"

Since it doesn't mention the trailing slash, it makes the error string very
weird for this URL: "file://localhost". But maybe good enough.

>> It actually has to be changed to
>>
>> if(ptr[0] && ('/' == ptr[1]))
>
> Now I am confused. Which case should it actually cover?

for "file://localhost/", ptr is made to point to "&path[10]" which is the byte
following the third slash. So ptr[0] is the trailing zero byte and we cannot
read ptr[1] as that is beyond our given string.

> By reverse engineering I made up a URL "file://localhost///etc/fstab" to get
> there ... but it does not look like a case we need to handle specially :-)
> So what is the purpose of this condition? Which URLs do we need it for?

Now you talk about the need, or no need, for the memmove() there. Yeah, it is
an attempt to avoid having two initial slashes but you're right that for *nix
at least having several slashes isn't a problem... I'm not sure how that is
treated by other systems though.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:  https://curl.haxx.se/mail/etiquette.html