cURL / Mailing Lists / curl-library / Single Mail

curl-library

[SECURITY ADVISORY] curl double-free in curl_maprintf

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 2 Nov 2016 08:09:01 +0100 (CET)

double-free in curl_maprintf
============================

Project cURL Security Advisory, November 2, 2016 -
[Permalink](https://curl.haxx.se/docs/adv_20161102D.html)

VULNERABILITY
-------------

The libcurl API function called `curl_maprintf()` can be tricked into doing a
double-free due to an unsafe `size_t` multiplication, on systems using 32 bit
`size_t` variables. The function is also used internallty in numerous
situations.

The function doubles an allocated memory area with realloc() and allows the
size to wrap and become zero and when doing so realloc() returns NULL *and*
frees the memory - in contrary to normal realloc() fails where it only returns
NULL - causing libcurl to free the memory *again* in the error path.

Systems with 64 bit versions of the `size_t` type are not affected by this
issue.

This behavior is triggable using the publicly exposed function.

We are not aware of any exploit of this flaw.

INFO

----
The Common Vulnerabilities and Exposures (CVE) project has assigned the name
CVE-2016-8618 to this issue.
AFFECTED VERSIONS
-----------------
This flaw exists in the following curl versions (and again, only on 32bit
versions).
- Affected versions: curl 7.1 to and including 7.50.3
- Not affected versions: curl >= 7.51.0
libcurl is used by many applications, but not always advertised as such!
THE SOLUTION
------------
In version 7.51.0, the memory growing functions will fail instead of letting
the size wrap.
A [patch for CVE-2016-8618](https://curl.haxx.se/CVE-2016-8618.patch) is
available.
RECOMMENDATIONS
---------------
We suggest you take one of the following actions immediately, in order of
preference:
  A - Upgrade curl and libcurl to version 7.51.0
  B - Apply the patch to your version and rebuild
  C - Make really sure you never send strings larger than 1GB into this funciton
TIME LINE
---------
It was first reported to the curl project on September 23 by Cure53.
We contacted distros_at_openwall on October 19.
curl 7.51.0 was released on November 2 2016, coordinated with the publication
of this advisory.
CREDITS
-------
This vulnerability was found during a Secure Open Source audit performed by
Cure53.
-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:  https://curl.haxx.se/mail/etiquette.html
Received on 2016-11-02