cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: libcurl crahes when an SFTP server's home directory is non-exist

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 17 Jun 2016 15:17:23 +0200 (CEST)

On Thu, 16 Jun 2016, $BCHOBE*OBCH(J _ wrote:

>> What about this fix to avoid that:
>
>> }
>> - else if(rc > 0) {
>> + else if(rc >= 0) {
>
> I am very sorry that I had incorrect observation of the rc value. It's
> timeout but error code is not set. So this fix won't work.

Then I guess I didn't understand your problem. How does it end up crashing?

> The root cause is indeed in libssh2. I will report this to libssh2
> development team.

Ok, and as a libssh2 hacker I will appreciate that. But since this crash is
within libcurl within an existing libssh2 release I think we need to also add
some extra checks in libcurl to make sure it'll work for all those using this
or older libssh2 versions!

-- 
  / daniel.haxx.se

-------------------------------------------------------------------
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2016-06-17