cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [RELEASE] curl and libcurl 7.49.0

From: Jan Ehrhardt <phpdev_at_ehrhardt.nl>
Date: Thu, 19 May 2016 00:41:48 +0200

On Wed, 18 May 2016 08:22:55 +0200 (CEST), in gmane.comp.web.curl.library
you wrote:

> o winbuild: add mbedtls support [36]

There was an addition in makefile.vc (*nix style wrapped):

!IF DEFINED(WITH_SSL) && DEFINED(ENABLE_WINSSL) || \
        DEFINED(WITH_SSL) && DEFINED(WITH_MBEDTLS) || \
        DEFINED(WITH_MBEDTLS) && DEFINED(ENABLE_WINSSL)

                !ERROR WITH_SSL, WITH_MBEDTLS and ENABLE_WINSSL \
                        are mutual exclusive options.

!ENDIF

The absence of parentheses around the && pairs give me the creeps. I guess
it is wrong, but even if it works OK, it is really confusing.

Besides that: it breaks build scripts with ENABLE_WINSSL=no, such as the
ones the PHP devs are using in https://github.com/winlibs/cURL because
WITH_SSL and ENABLE_WINSSL are both defined in these build scripts.

A little bit later in the process I am running into this error:

        cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB /I. /I ../lib
/I../include /nologo /W3 /EHsc /DWIN32 /FD /c /DBUILDING_LIBCURL
/I"../../win32build.vc14/include" /DUSE_OPENSSL /I"../
../win32build.vc14/include/openssl" /DUSE_NGHTTP2 /DHAVE_ZLIB_H
/DHAVE_ZLIB /DHAVE_LIBZ /DHAVE_LIBSSH2 /DHAVE_LIBSSH2_H /DLIBSSH2_WIN32
/DLIBSSH2_LIBRARY /DUSE_LIBSSH2 /I../../win32build.vc14/include/libssh2
/DUSE_WIN32_IDN /DWANT_IDN_PROTOTYPES /DUSE_IPV6 /DUSE_WINDOWS_SSPI
/Fo"..\builds\libcurl-vc14-x86-release-static-ssl-static-zlib-static-ssh2-static-ipv6
-sspi-obj-lib/vauth/vauth.obj" ..\lib\vauth\vauth.c
vauth.c
C:\php-sdk\curl-src\lib\vauth\vauth.c : fatal error C1083: Cannot open
compiler generated file:
'C:\php-sdk\curl-src\builds\libcurl-vc14-x86-release-static-ssl-static-zlib-static-ssh2-static-ipv6-sspi-obj-lib\vauth\vauth.obj':
No such file or directory
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
Studio 14.0\VC\BIN\cl.exe"' : return code '0x1'
Stop.

I have to manually create the directory
C:\php-sdk\curl-src\builds\libcurl-vc14-x86-release-static-ssl-static-zlib-static-ssh2-static-ipv6-sspi-obj-lib\vauth\
to overcome this error.

Both errors are nog big deal, but I was surprised that the winbuild
scripts failed all of a sudden.

Jan

-------------------------------------------------------------------
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2016-05-19