No I haven't looked at adding/adjusting tests, but I should. This patch was
inspired by a news story about a gopher server restarting operations, so I
thought I'd try to connect. My perception of what followed (as determined
by writing code that I thought should work, observing results, tcpdump, and
temporary debug adjustments to libcurl. I'll look to finding a place for a
test for this code. What will have to be approved is 1) my
interpretation/rationale for what I considered the initial failure, and
then 2) the small code adjustment I made to move to operations as described
in "1)".

I'll look for gopher tests and see about finding space to test what we're
talking about here.

Thanks for your comments Daniel.

Regards,

-bch
On Mar 8, 2016 6:27 AM, "Daniel Stenberg" <daniel_at_haxx.se> wrote:

> On Fri, 26 Feb 2016, bch wrote:
>
> What I suspect that original code was going was parsing the content from a
>> gopher server (and in fact, taking some shortcuts that may have happened to
>> work for original use-case). The actual URI is the second component of an
>> appropriate gopher line, and to be used unadulterated. What I think the
>> previous code was supposed to do is take a raw line from a gopher server
>> and eliminate it's "status", and use the user-visible component of the
>> returned content as the URI. That sort of parsing is better left for a
>> higher-level client. This patch removes the test of path length and
>> stripping characters, but preserves tab handling (arguably still removable)
>> and escaping.
>>
>
> So our existing gopher tests aren't good enough or are they plain wrong?
> Have you looked at adding a test that verifies what your patch fixes?
>
> --
>
> / daniel.haxx.se
> -------------------------------------------------------------------
> List admin: https://cool.haxx.se/list/listinfo/curl-library
> Etiquette: https://curl.haxx.se/mail/etiquette.html

-------------------------------------------------------------------
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2016-03-08