cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: CURLOPT_SSH_PUBLIC_KEYFILE does not work as documented

From: Elliť Computing Open Source Program <opensource_at_elliecomputing.com>
Date: Thu, 14 Jan 2016 21:07:25 +0100

>From: Kamil Dudka
>The CURLOPT_SSH_PUBLIC_KEYFILE option is documented to handle empty
>strings specially, as implemented in curl-7_25_0-31-g05a443a:
>
> https://github.com/bagder/curl/commit/curl-7_25_0-31-g05a443a
>
>This behavior was (unintentionally?) broken in curl-7_38_0-47-gfa7d04f:
>
> https://github.com/bagder/curl/commit/curl-7_38_0-47-gfa7d04f
>
>Note that the behavior is still available if NULL is used instead of an
>empty string (at least with libcurl API). Now the question is whether
>we want to fix the implementation such that it works as documented, or
>fix the documentation to match the current behavior?
>
>Kamil

One reason for that "empty string same as NULL" behavior is that some higher
level APIs (cURLpp) does not handle NULL options.
It was then not possible just set the option to NULL, only to "empty string"
to get the behavior.

If possible could you restore the behavior ?

Or just not setting the option at all could do the same ?

Best regards
Armel Asselin

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2016-01-14