cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: multiplexing issues on libcurl HTTP2

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 8 Jan 2016 22:58:53 +0100 (CET)

On Sat, 9 Jan 2016, Tatsuhiro Tsujikawa wrote:

> ​Confirmed it does not work quite right. nghttp does work, so inspecting
> libcurl code and found this:
> https://github.com/bagder/curl/blob/c338d8cf9c173858d176b73ef80787907bd2d3bf/lib/http2.c#L414
>
> This basically ignores frame with stream ID == 0, including SETTINGS.

Ouch, what a mistake. Thanks a lot for pointing it out. This regression came
with 5778e6f5 and landed in 7.44.0. I really should get proper http2 testing
fixed in the test suite sooner rather than later to help us avoid regressions
like this in the future.

Fix pending.

-- 
  / daniel.haxx.se

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2016-01-08