cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH v2] rawstr: Speed up Curl_raw_toupper by 40%

From: Daniel Stenberg <>
Date: Mon, 2 Nov 2015 20:39:20 +0100 (CET)

On Mon, 2 Nov 2015, Lauri Kasanen wrote:

> +#if ('z' - 'a' == 25) && ('Z' - 'A' == 25)

I have one concern with this method: it checks that the compiler is using
ascii, not necessarily that the target host is using it. I'm not sure the
distinction actually matters.

However, I also think that CURL_DOES_CONVERSIONS is the define used elsewhere
within libcurl for the system that uses non-ASCII so we can probably use that
for this check as well and then my concern will go away.

List admin:
Received on 2015-11-02