On 10/22/2015 8:15 AM, Gisle Vanem wrote:
> "Ray Satiro via curl-library" <curl-library_at_cool.haxx.se> wrote:
>
>> Thanks, landed in https://github.com/bagder/curl/commit/c238d4d
>>
>> In the future can you attach a patch? In Thunderbird the leading
>> whitespace is stripped and I can't do a git apply without manually
>> editing the patch or pass the raw contents of your e-mail (view
>> source) to a base64 decoder.
>
> Okay. I have problems making a 'git pull' request. I prefer the method
> in section 3.3 of docs/CONTRIBUTE. So an email attachment is better?

TL;DR: yes please.

I no longer have your original e-mail but I'll speculate this may have
something to do with flowed messaging. This most recent e-mail you sent
was marked flowed, so it's possible the e-mail you sent your patch in
was marked that way. Thunderbird detects the flowed setting in the
sender's e-mail headers and if it's marked flowed and flowed message
display processing isn't disabled it strips the trailing space. So if
the diff you submit has blank common lines (ie a line with a single
space) those spaces are stripped. There is an option
mailnews.display.disable_format_flowed_support I could try but if
Thunderbird receives an e-mail marked flowed I would expect it to
process it that way.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-10-23