On 08/21/2015 12:53 AM, Daniel Stenberg wrote:
> On Tue, 18 Aug 2015, Razvan Cojocaru wrote:
>
>> This patch addresses known bug #76, where on 64-bit Windows SOCKET is
>> 64 bits wide, but long is only 32, making CURLINFO_LASTSOCKET unreliable.
>
> Nice! Just two minor things:
>
> 1. I think we can do better with the name. It was never that good to
> begin with, as the "last" part isn't that clear what it refers to. How
> about CURLINFO_ACTIVESOCKET ?

Sure, I'll modify the patch and send out V2.

> 2. Documentation. That's a new option, we need it documented so that
> users can actually figure out how and when to use it!

Right, do you mean docs/libcurl/curl_easy_getinfo.3? Any other places?

Thanks,
Razvan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-08-21