cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: CURLINFO_LASTSOCKET Windows 64 patch

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sat, 15 Aug 2015 23:33:49 +0200 (CEST)

On Fri, 14 Aug 2015, Razvan Cojocaru wrote:

> Known bug #76 [1] states that "the SOCKET type in Win64 is 64 bits large
> (and thus so is curl_socket_t on that platform), and long is only 32 bits.
> It makes it impossible for curl_easy_getinfo() to return a socket properly
> with the CURLINFO_LASTSOCKET option as for all other operating systems."

> 174 *(long long *)param_longp = sockfd;

That could be done, but then that'd break existing programs that use
CURLINFO_LASTSOCKET where long and long long are not the same size. So no,
that is unfortunately not a good fix.

I think a better fix is probably to introduce a CURLINFO_LASTSOCKET
replacement that simply returns a pointer to a curl_socket_t instead of a
long.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2015-08-16