On Wed, 1 Jul 2015, moparisthebest wrote:

> Attached is the (hopefully) final patch implementing pinned public key hash
> support.

Thanks! This looks a really nice patch and I've just merged it!

> Also attached is a separate optional patch that creates a new base64
> function

I think it lacks some finish:

- Curl_base64_decode_nomalloc has a comment header that uses the wrong
function name and claims it is unit tested, when it isn't (Curl_base64_decode
is however) (I'd prefer to have a unit test added!)

- I'm not entirely happy with the way the *_nomalloc version simply duplicates
the base64 decoding logic so that it then appears on two places. Can't we
somehow merge them into a unified function so that the key decoding logic is
shared?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html