On Mon, 27 Apr 2015, Nico Williams wrote:

> This breaks tests like test206, which effectively send junk in the CONNECT
> response.

Hopefully changing behavior _does_ break one or more tests. It only proves we
actually verified the existing behavior. But changed behavior would then also
require changed and updated test cases accordingly...

> At a minimum the tests need fixing, while removing the Content-Length and
> Transfer-Encoding handling from Curl_proxyCONNECT() could wait for another
> day.

Let's remember this:

    A server MUST NOT send any Transfer-Encoding or Content-Length header
    fields in a 2xx (Successful) response to CONNECT.

And let me emphasize the "2xx" part there. A CONNECT response can be a lot
more than just 2xx responses and both Transfer-Encoding or Content-Length
headers are frequently used in such responses. We cannot remove the support
for them without breaking numerous applications.

We can make sure to bail out nicely and properly though if they occur in 2xx
responses. And add tests that verify that!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html