On Thu, Mar 26, 2015 at 2:46 PM, Ray Satiro via curl-library
<curl-library_at_cool.haxx.se> wrote:
> On 3/26/2015 6:50 AM, Kyle L. Huff wrote:
>>>

> Well no that isn't what it does, it requires the callback if NO_FILESYSTEM
> and is optional otherwise. Anyway the if statement is wrong because I didn't
> check peer verify.

Okay, I see.

> I was basically suggesting you refactor. Look at [1] to
> see what I mean.

I'm not opposed to re-factoring as you have suggested, but other than
adding a `failf` statement to my patch, I am not clear on why/what
should be re-factored. Perhaps I am missing something obvious (note,
I am not a programmer by trade, so this might be the case!), but I
don't see the improvement. Functionally, both versions appear they
would produce the same result, however, re-factoring it as you propose
creates an additional/redundant check of `data->set.ssl.fsslctx` when
using NO_FILESYSTEM.

Is there a specific case/problem that you are trying to avoid with the
re-factor?
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-03-27