cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] cyassl: remove undefined reference to CyaSSL_no_filesystem_verify & add support for CURLOPT_SSL_CTX_FUNCTION

From: Kyle L. Huff <kyle.huff_at_curetheitch.com>
Date: Wed, 25 Mar 2015 12:10:55 -0400

On Sun, Feb 22, 2015 at 3:05 PM, Kyle L. Huff <kyle.huff_at_curetheitch.com> wrote:
> The attached patches remove the reference to
> "CyaSSL_no_filesystem_verify", and enables CURLOPT_SSL_CTX_FUNCTION
> when using CyaSSL.

I would like to gauge if there is any interest in implementing the
above mentioned changes in cURL.

I realize that this is a very low priority, and I am just trying to
identify if I will need to maintain local patches within my projects
own build system.

My argument(s) for inclusion -

Patch 1 -
    The changes in the first patch only affect those using CyaSSL and
NO_FILESYSTEM, so it probably only matters to a very small number of
users - maybe only me. Given this very small impact, my only arguments
for patch 1 are -

    1.) The original code (appears to me) to be incorrect (undefined references)
    2.) Portability when using CyaSSL (systems without a filesystem)

Patch 2 -
    This implements context callback functionality when using CyaSSL,
which has a potentially wider audience/impact, and my arguments are -

    1.) Consistency with the usage of other SSL libraries
(CURLOPT_SSL_CTX_FUNCTION)
    2.) Versatility

None of those are really very strong arguments for inclusion, the
entire matter is rather insignificant. Again, I am just trying to plan
accordingly.

Thanks for cURL, and all of the work that goes into making it so
great. Long live cURL!

Regards,
Kyle L. Huff
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-03-25