cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Fixing CURLOPT_RESOLVE

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sat, 14 Mar 2015 18:37:59 +0100 (CET)

On Sun, 8 Mar 2015, Ray Satiro via curl-library wrote:

>> I've started some work on fixing CURLOPT_RESOLVE. I have fixed it so that
>> multiple addresses can be stored for each host:port. You can see a branch
>> comparison at [1].

> I didn't get any feedback on this so I just went ahead and wrote it in the
> way I think is most correct. https://github.com/jay/curl/commit/1ae8b1f

Thanks Ray, sorry for being slow to respond to this. Looks great!

Can you figure out some basic unit tests we can add for this so that we can be
reasonable sure the functions all work as intended after these changes?

Also, you mention support for multiple addresses but I don't see any change in
the docs regarding that and I think it should get some mention (as then I
won't have to ask you how they are supposed to work...)

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2015-03-14