On Sun, 18 Jan 2015, John E. Malmberg wrote:

> > I tried to find all the instances and fix them for the last release,
> > as I realised I had broken non 64-bit compiler builds, but as I don't
> > such a compiler myself I unfortunately missed some :(
> >
> > Which file did you notice this in as I'd like to fix it there too?
>
> lib/curl_ntlm_core.c:
>
> X 28064 #if defined(HAVE_LONGLONG)
> X 28065 long long tw;
> X 28066 #else
> X 28067 __int64 tw;
> X 28068 #endif

Cheers.

> The assumption is that if the compiler does not have long long,
> that it has __int64. I do not see a test in config.h for __int64.

That is in the function Curl_ntlm_core_mk_ntlmv2_resp() which is only included if USE_NTLM_V2 is not zero which won't be the case when 64-bit integers aren't supported due to the following in the header file:

#if !defined(USE_NTLM_V2) && USE_NTRESPONSES && (CURL_SIZEOF_CURL_OFF_T > 4)
#define USE_NTLM_V2 1
#endif

> I discovered that a new option had been added to configure that
> needed to be disabled on VAX since the external libraries to
> support NTLM have not been ported to VAX.

Yes - we added support for SMB in v7.40.0. However, all the SMB code is disabled when NTLM is not available.

If you had to explicitly disable SMB I would consider that a bug - which we should try and identify and fix.

> Same issue in lib/smb.c:

That is protected via the following at the top of the source file:

#if !defined(CURL_DISABLE_SMB) && defined(USE_NTLM) && \
    (CURL_SIZEOF_CURL_OFF_T > 4)

Any assistance / additional info you can provide on a possible configure bug would be very much appreciated.

Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-01-18