curl-library
Re: [PATCH 00/11] UNIX domain sockets support
Date: Wed, 10 Dec 2014 16:21:30 +0100
On 10 December 2014 at 13:12, Daniel Stenberg <daniel_at_haxx.se> wrote:
> I'll push a rename and see if that flies better.
That fixed it (http://curl.haxx.se/dev/log.cgi?id=20141210143221-16040)
There's a couple of 'not reached' warnings there, not related, but as
I noticed it just now I'll at least make a record of it:
"../../curl/lib/curl_ntlm_wb.c", line 306: warning: statement not reached"
and yes, it's not reached.. look here:
while(1) {
ssize_t size;
char *newbuf;
size = sread(conn->ntlm_auth_hlpr_socket, buf + len_out, NTLM_BUFSIZE);
if(size == -1) {
if(errno == EINTR)
continue;
goto done;
}
else if(size == 0)
goto done;
len_out += size;
if(buf[len_out - 1] == '\n') {
buf[len_out - 1] = '\0';
goto wrfinish;
}
newbuf = realloc(buf, len_out + NTLM_BUFSIZE);
if(!newbuf) {
free(buf);
return CURLE_OUT_OF_MEMORY;
}
buf = newbuf;
}
goto done; <---- This one isn't reachable.
-Tor
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-12-10