On Mon, Nov 17, 2014 at 06:06:23PM +0100, Peter Wu wrote:
> This is the second revision of the earlier patchset[1] which fixes tests
> which broke when ran under LD_PRELOAD=libhostname.so with ASAN enabled
> (cmake without CURLDEBUG). To facilitate that change, it was necessary
> to change from a command string to a list of command arguments.

Is this the only use case for this patch set? It's pretty intrusive, makes
it more difficult to see the control flow, and can result in surprises when
what seems like a normal shell command-line has subtle differences. If this is
the only case where this patch helps, I would rather see if there is another
approach to solving it (e.g. linking sethostname.c directly into the test
binary).

>>> Dan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-17