On 11/17/2014 11:54 AM, Peter Wu wrote:
>> Peter, please take a look at my patch for CMP0054 warnings:
>>
>> CMake: Simplify if() conditions on check result variables
>> http://thread.gmane.org/gmane.comp.web.curl.library/44245
>
> That patch looks OK to me!

Thanks. I don't have direct commit access so please give the
+1 in that thread so someone else can commit.

>>> +function(_add_if label)
>>> + # TODO need to disable policy CMP0054 (CMake 3.1) to allow this indirection
>>> + if(${ARGN})
>>
> I was told in #cmake that constructs such as `if(${ARGN})` are
> deprecated in favor of `if(ARGN)`

That is not true, and that is not what CMP0054 does. It is
just that to avoid CMP0054 warnings without explicitly setting
the policy to NEW (so that code can work in older CMake still)
it is sometimes easier to not explicitly dereference a variable
in certain if() contexts.

You can remove the above-mentioned comment.

Thanks,
-Brad

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-17