cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH 2/7] pipelining: Fix connection handling under timeouts.

From: m brandenberg <>
Date: Thu, 13 Nov 2014 18:02:48 -0500 (EST)

On Tue, 11 Nov 2014, Daniel Stenberg wrote:

> ... as I still question that "bits.timedout" is necessary because I think we
> shouldn't add requests to a connection that is marked for close so
> connclose()
> should be enough. I thus think IsPipeliningPossible() should return FALSE if
> conn->bits.close is set to make sure it doesn't happen.

In the 1420 bug report, in my first attempt at a fix, I did exactly
that. The 'bits.close' flag was set rather frequently and the
result was the pipelining was mostly defeated. Second discovery
doing that was that the testing framework doesn't really test
whether pipelining occurs (it blew right over this).

Monty Brandenberg, Software Engineer                               MCB, Inc.                                             P.O. Box 425292                                   Cambridge, MA  02142-0006
List admin:
Received on 2014-11-14