cURL / Mailing Lists / curl-library / Single Mail


Re: Using git to regenerate patches (was Re: [PATCH 1/7] Comment and debug output fixes.)

From: Daniel Stenberg <>
Date: Tue, 11 Nov 2014 00:26:41 +0100 (CET)

On Mon, 10 Nov 2014, Carlo Wood wrote:

>> An easy way is to just commit the fix in the local branch where you
>> do your patch series, and then 'git rebase -i' and move the fix next
>> to the one one being fixed and mark it as 'fixup'. Done.
> I know git :p.

Then don't come telling it is hard or "unnatural" to do updated patch series
with it. Heck, that's even the standard way of developing git itself! And they
have way more patch traffic on their mailing list than we do.

> I can create local-only branches and do rebasing there but then I still have
> to apply the incremental patches the normal way to the published repository;
> all in all, it's just extra work.

Extra work for the individual developers for the convenience and lesser effort
for the readers and reviewers of the patch is preferred. That scales much
better than vice versa.

> For each submitted patch I will create a new (local) branch

Sounds overly complicated to me, but to each their own.

List admin:
Received on 2014-11-11