cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH 0/2] CMake: Fix order-dependent header and library checks

From: Brad King <>
Date: Fri, 07 Nov 2014 13:52:25 -0500

On 11/07/2014 01:37 PM, Steve Holme wrote:
> I'm sure Daniel will review this


>> Revert commit curl-7_39_0~160 (Cmake: Avoid cycle directory dependencies,
>> 2014-08-22) and add a comment explaining the purpose of the original code.
> I would recommend referencing the original commit in commit comments via a
> shortened version of the SHA-1 commit ID (I find that 9 or 10 characters
> are sufficient) so that tools can hyperlink to it as well as making a human
> search easier.

I'm happy to use whatever style this community prefers. FYI, git.git
switched from using the short sha1 to $(git describe --contains $sha1),
and I was given exactly the opposite advice when sending patches there
with short sha1s in the commit messages. IIUC the reasons include:

* References relative to tags tell the human about when the change
  was made relative to the project history.

* They would also survive a future rewrite when Git switches to something
  other than sha1.

The viewers can always be improved to recognize such references and make
them into links.


List admin:
Received on 2014-11-07