cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] configure: adjust tests to avoid -Werror breakage

From: Daniel Stenberg <>
Date: Tue, 4 Nov 2014 08:40:16 +0100 (CET)

On Tue, 4 Nov 2014, Peter Wu wrote:

> These series allow ./configure to run when CFLAGS contains -Werror.

While I generally strongly agree with having C code comply with -Werror and
other strict rules, this is a pretty invasive change in territory that is by
definition very conservative and fragile. The configure script serves its
purpose the best on the platforms we rarely use and none of us regular
contributors ever use. We move slow and with caution here.

This said, other than pedentic reasons, why do you want -Werror in CFLAGS for
configure? We've offered --enable-werror since forever and it is generally
even better since it actually also checks the compiler and it only affects the
generated output and not every single test configure itself does.

> This patch was created because configure was bailing out due to a linking
> error. (due to a missing 'int' return value for main IIRC).

C has a default type of int and that test has worked on a fairly large amount
of compilers and systems already... I assume you meant that it too failed with
-Werror in CFLAGS?

> - strcasecmp (checked twice, once in configure, once in curl-functions.m4)

It is indeed checked twice, but the checks are slightly different so I've
played safe and kept the second one around.

List admin:
Received on 2014-11-04