On Tue, 28 Oct 2014, Carlo Wood wrote:

> I finished all testing and wrote fixes that addresses all problems that I had
> with pipelining.
>
> https://github.com/bagder/curl/pull/121

Thank you for your hard work on this.

Whilst I've had a quick look at the code, I'm not one of the reviewers here with the necessary experience in the pipelining code to pass judgement on the technical merits of your patches ;-)

However, I just wanted to give you a quick heads up about our review process which will assist us in reviewing your patch set much more quickly.

The commit comments whilst wrap at 72 characters the title of them doesn't follow our commit comment standard which is:

[area]: [short line describing the main effect]

For example:

sasl_sspi: Fixed typo in comment

(from one of my own recent 'minor' commits)

or

multi: Prevent a bundle being deleted while closing a broken pipe

Additionally we're not great fans of pull requests and much prefer git patch files being posted to the mailing list, especially when other commits happen in the middle - Not only is it easier for us to review the files it is much easier to rebase the files in this situation for example and also helps us avoid merges in the log.

For more information on both of these points please see:

http://curl.haxx.se/dev/contribute.html

Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-10-29