curl-library
RE: [PATCH] smb/cifs
Date: Wed, 1 Oct 2014 17:34:24 +0000
>
> 1 - your patch leaks memory in OOM situations (we want perfect cleanup in
> all
> error situations as well), this means that if you do 3 memory allocations
> and the 3rd call fails, the first two must free their memory when the
> failure is returned.
>
Do the done and disconnect callbacks not happen after an OOM error?
-Bill
________________________________
This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-10-01