cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] Implement Public Key Pinning

From: Daniel Stenberg <>
Date: Tue, 30 Sep 2014 00:19:21 +0200 (CEST)

On Wed, 24 Sep 2014, moparisthebest wrote:

> What else should be done to get this accepted into curl?

Thanks for this, and sorry for being so slow to review your work. It looks
pretty good. I think the documentation for these features should mention that
only the OpenSSL backend supports this feature - as we have a large amount of
users using other backends and they will look for answers why.

The test cases fail. When I run test 2034 and then look in log/trace2034 it
includes a fairly telling piece:

00:06:15.475365 == Info: SSL certificate problem: unable to get local issuer
00:06:15.475980 == Info: Marked for [closure]: Failed HTTPS connection

Test 2034 also has a pretty lousy name, and the protocol check is wrong (which
will be obvious once the TLS part is made to work).

Test 2035 fails the same way and also has a misleading name.

The test name is what is visible to users who run the tests so we should take
care and provide a brief description of the test there.

List admin:
Received on 2014-09-30