cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH v2 1/2] Ensure progress.size_dl/progress.size_ul are always >= 0

From: Brandon Casey <drafnel_at_gmail.com>
Date: Sat, 6 Sep 2014 16:14:11 -0700

On Sat, Sep 6, 2014 at 2:34 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Thu, 4 Sep 2014, Brandon Casey wrote:
>
>> I just wanted to check in and see if you'd had a chance to look at these
>> patches and make sure they were acceptable.
>
>
> I'd love to! When I tried your patches just now and test 579 failed. Can you
> please squash your work into a single patch and re-send a version you think
> look decent and I can take another look?

The patches I submitted still seem to apply cleanly and pass the tests
on top of current master for me. How did you apply them? Did you
save the emails and apply them using 'git am'? Or something else?

Is it possible there is a dependency problem in the build system and
things are not being rebuilt that should be? i.e. 'make clean' is
needed? I encountered something like this but did not investigate.
For me, I think progress.c was not getting rebuilt.

-Brandon
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-09-07