cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Compile with latest nghttp2

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 26 Aug 2014 14:47:16 +0200 (CEST)

On Tue, 26 Aug 2014, Tatsuhiro Tsujikawa wrote:

> The attached patch fixes build error with latest nghttp2.

Lovely, what do you think about also bumping the detection of nghttp2 in
curl's configure like this, to make it only detect nghttp2 with this newer
API?

diff --git a/configure.ac b/configure.ac
index 3c70540..d51c7e5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2758,11 +2758,11 @@ if test X"$want_h2" != Xno; then

      LDFLAGS="$LDFLAGS $LD_H2"
      CPPFLAGS="$CPPFLAGS $CPP_H2"
      LIBS="$LIB_H2 $LIBS"

- AC_CHECK_LIB(nghttp2, nghttp2_session_client_new,
+ AC_CHECK_LIB(nghttp2, nghttp2_session_callbacks_set_send_callback,
        [
         AC_CHECK_HEADERS(nghttp2/nghttp2.h,
            curl_h2_msg="enabled (nghttp2)"
            NGHTTP2_ENABLED=1
            AC_DEFINE(USE_NGHTTP2, 1, [if nghttp2 is in use])

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2014-08-26