On Sat, 16 Aug 2014, Daniel Hwang wrote:

> I have executed http://curl.haxx.se/mail/archive-2010-05/0066.html. The
> objective was to add an option to consider "connection refused" errors as
> transient in a retry.
>
> I have tested my changes using the following approach:
> https://gist.github.com/gnawhleinad/6860bedb4de5a3776ecd#file-readme-md

Thanks a lot for helping out to improve our project!

I have a little issue with this patch (apart from it not having any docs nor
test cases accompanying it):

- It doesn't really do what it claims. Or rather it does a lot more!

The naming of this option gives the user the impression that this retries for
connection refused problems, while in reality it makes curl retry for _all_
and _any_ connection failures that occur.

I could be fine with that, if that's what you intend but we really can't have
the option named like this then!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html